Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add observation YAMLs for AMSU-A, ATMS, SSMIS, SEVIRI, and AVHRR #360

Merged
merged 10 commits into from
Feb 16, 2023
Merged

Add observation YAMLs for AMSU-A, ATMS, SSMIS, SEVIRI, and AVHRR #360

merged 10 commits into from
Feb 16, 2023

Conversation

emilyhcliu
Copy link
Collaborator

@emilyhcliu emilyhcliu commented Feb 15, 2023 •
edited
Loading

Add observation YAMLs for AMSU-A, ATMS, SSMIS, SEVIRI, and AVHRR
Pass benchmarks are provided in the YAMLs for unit tests.

Please see the following JEDI-T2O issues for documentation and validation results:
JEDI-T2O#42 --- AMSU-A (100% match)
JEDI-T2O#44 --- ATMS (Difference: 1 point for NPP and 5 points for N20)over south sea ice area from hydrometer check)
JEDI-T2O#55 --- SSMIS with Azadeh (100% match)
JEDI-T2O#53 --- AVHRR with Azadeh ( Difference: 1 point for N19)
JEDI-T2O#52 --- SEVIRI with Xuanli (100% match)

Summary plots for validation will be posted later.

@ADCollard
Copy link
Collaborator

@emilyhcliu Apparently the develop version was not pointing to the right UFO build after all. I just pushed a commit to update CMakeLists.txt to point at:

  ecbuild_bundle( PROJECT ufo   GIT "https://github.com/jcsda/ufo.git" BRANCH feature/gdasapp_ufo )

@ADCollard
Copy link
Collaborator

@emilyhcliu run_ufo_hofx_test.sh appears to still be pointing at Cory's data directories. Can you update, please, for both Hera and Orion (there are failures for AVHRR and Seviri).

@ADCollard
Copy link
Collaborator

@emilyhcliu I'll work on the final AMSU-A/ATMS QC in the morning. There will not be exact agreement, but we should be screening out obs with missing values anyway. We don't want to be pointing to a version of CRTM that is not under change control.

@ADCollard
Copy link
Collaborator

ADCollard commented Feb 16, 2023 •
edited
Loading

@emilyhcliu I'll work on the final AMSU-A/ATMS QC in the morning. There will not be exact agreement, but we should be screening out obs with missing values anyway. We don't want to be pointing to a version of CRTM that is not under change control.

.... actually I am going to see if I can make a modified CRTM tag....

@emilyhcliu
The surface height should be a GeoVaLs instead of MetaData for observ…
478d4e6 
…ation. Therefore, change MetaData/heightOfSurface to GeoVaLs/surface_geopotential_height
@emilyhcliu
Merge branch 'feature/yaml4radiance' of https://github.com/NOAA-EMC/G…
2ca214e 
…DASApp into feature/yaml4radiance
@emilyhcliu
Copy link
Collaborator Author

@emilyhcliu run_ufo_hofx_test.sh appears to still be pointing at Cory's data directories. Can you update, please, for both Hera and Orion (there are failures for AVHRR and Seviri).

Yes

@ADCollard
Copy link
Collaborator

With the latest changes, I get the relevant tests to pass on Hera. I will look in detail at the summary output plots and will also test on Orion:

> export machine=hera
> export GDASApp=/scratch1/NCEPDEV/da/Andrew.Collard/git/GDASApp_Emily 
> ./test_yamls.sh 
aircraft.yaml Fails (boo!)
amsua_metop-a.yaml Passes (yay!)
amsua_metop-b.yaml Passes (yay!)
amsua_metop-c.yaml Passes (yay!)
amsua_n15.yaml Passes (yay!)
amsua_n18.yaml Passes (yay!)
amsua_n19.yaml Passes (yay!)
atms_n20.yaml Passes (yay!)
atms_npp.yaml Passes (yay!)
avhrr3_metop-a.yaml Passes (yay!)
avhrr3_metop-b.yaml Passes (yay!)
avhrr3_n18.yaml Passes (yay!)
avhrr3_n19.yaml Passes (yay!)
satwind.yaml Fails (boo!)
seviri_m08.yaml Passes (yay!)
seviri_m11.yaml Passes (yay!)
sfcship.yaml Fails (boo!)
sfc.yaml Fails (boo!)
sondes_ps.yaml Fails (boo!)
sondes.yaml Fails (boo!)
ssmis_f17.yaml Passes (yay!)
ssmis_f18.yaml Passes (yay!)

CoryMartin-NOAA
CoryMartin-NOAA approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, but assuming it will be all good once @ADCollard finishes his tests. Thanks a lot @emilyhcliu for all of your hard work on this and getting it in GDASApp!

@ADCollard
Copy link
Collaborator

This IODA PR broke the eva scripts which meant I could not produce the output plots. A one line change to `ush/eva/gen_eva_obs.yaml' fixes this and was pushed here.

@ADCollard
Copy link
Collaborator

@emilyhcliu @CoryMartin-NOAA

I am happy with the PR now. I am including the plots that show the biggest discrepancies below, but I think these are all within reasonable bounds.
ObsErr_Difference_diag_amsua_metop-a

ObsErr_Difference_diag_amsua_n18

ObsErr_Difference_diag_amsua_n19

QCCount_Diff_diag_atms_n20

QCCount_Diff_diag_atms_npp

QCCount_Diff_diag_avhrr3_n19

ADCollard
ADCollard approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@ADCollard ADCollard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CoryMartin-NOAA I approve this request but to be doubly sure (as I have been making multiple changes to this PR myself) can you do a clean checkout and build of this branch and run ush/ufoeval/test_yamls.sh as in this comment?

Note that there should be no need to change any files as long as the GDASApp and machine environment variables are set correctly.

@CoryMartin-NOAA
Copy link
Contributor

note that I also had to set $STMP to get this to run but so far it says:

./test_yamls.sh 
aircraft.yaml Fails (boo!)
amsua_metop-a.yaml Passes (yay!)
amsua_metop-b.yaml Passes (yay!)
amsua_metop-c.yaml Passes (yay!)
amsua_n15.yaml Passes (yay!)
amsua_n18.yaml Passes (yay!)
amsua_n19.yaml Passes (yay!)
atms_n20.yaml Passes (yay!)

I'm impatient and going home now but I think this is sufficient to say it is ready to merge, thus I will do so :-)

@CoryMartin-NOAA CoryMartin-NOAA merged commit 13e3951 into develop Feb 16, 2023
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/yaml4radiance branch February 16, 2023 22:34
@emilyhcliu emilyhcliu mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@ADCollard ADCollard ADCollard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilyhcliu @ADCollard @CoryMartin-NOAA